New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate `role_name` in `meta/main.yml` #1042

Open
chouseknecht opened this Issue Aug 8, 2018 · 6 comments

Comments

Projects
4 participants
@chouseknecht
Member

chouseknecht commented Aug 8, 2018

During the Galaxy CLI Developer Workflow meeting we decided that Galaxy and Mazer should no longer synthesize the role (or repository) name, and therefore role_name needs to be deprecated.

For reference see: https://docs.google.com/document/d/1nx65quXCyYORNel72rRCovyQo_qO5fhHlqrnKyYNlYU/edit?usp=sharing

To let users know about this change, we need to start issuing a deprecation warning in the import output whenever role_name is found in meta/main.yml.

@chouseknecht

This comment has been minimized.

Show comment
Hide comment
@chouseknecht

chouseknecht Aug 8, 2018

Member

Back port this to 3.0.

Member

chouseknecht commented Aug 8, 2018

Back port this to 3.0.

@chouseknecht chouseknecht added this to To do in Backend via automation Aug 8, 2018

@chouseknecht chouseknecht added this to the 3.1 Sprint 2 milestone Aug 8, 2018

@chouseknecht

This comment has been minimized.

Show comment
Hide comment
@chouseknecht

chouseknecht Aug 8, 2018

Member

See corresponding Mazer issue #115

Member

chouseknecht commented Aug 8, 2018

See corresponding Mazer issue #115

@chouseknecht chouseknecht modified the milestones: 3.1 Sprint 2, 3.1.0 Aug 9, 2018

@joshbenner

This comment has been minimized.

Show comment
Hide comment
@joshbenner

joshbenner Aug 11, 2018

Will there be any way to have the Galaxy-hosted role name be different than the GitHub-hosted repo name?

joshbenner commented Aug 11, 2018

Will there be any way to have the Galaxy-hosted role name be different than the GitHub-hosted repo name?

@chouseknecht

This comment has been minimized.

Show comment
Hide comment
@chouseknecht

chouseknecht Aug 23, 2018

Member

Marking as blocked, until we re-confirm this change with @tima and the product team.

Member

chouseknecht commented Aug 23, 2018

Marking as blocked, until we re-confirm this change with @tima and the product team.

@brtknr

This comment has been minimized.

Show comment
Hide comment
@brtknr

brtknr Sep 3, 2018

Deprecating role_name is a terrible idea considering the fact that this is what people started doing to give their role the name they actually wanted rather than ansible_role_blah_blah... given than the regex to remove the ansible_role part was removed quite recently.... this is going to be another costly blow and major annoyance to many users who have just reconfigured their pipelines.

Also, why did you remove the hyphens? Only noticed this change today and this seems like another, quite frankly, poorly justified change that adds little benefit.

brtknr commented Sep 3, 2018

Deprecating role_name is a terrible idea considering the fact that this is what people started doing to give their role the name they actually wanted rather than ansible_role_blah_blah... given than the regex to remove the ansible_role part was removed quite recently.... this is going to be another costly blow and major annoyance to many users who have just reconfigured their pipelines.

Also, why did you remove the hyphens? Only noticed this change today and this seems like another, quite frankly, poorly justified change that adds little benefit.

@oneswig

This comment has been minimized.

Show comment
Hide comment
@oneswig

oneswig Sep 3, 2018

A datapoint for your consideration:

As users of Galaxy our setup is broken by this proposal. The repos that back our Galaxy roles are in some cases widely used, forked and cloned. They all use the implicit naming convention of an ansible-role- prefix.

We have just been hit by having all our roles unexpectedly renamed to use underscores. What do you suggest users like us (and users of our roles) should do to maintain consistent developer and user experiences?

oneswig commented Sep 3, 2018

A datapoint for your consideration:

As users of Galaxy our setup is broken by this proposal. The repos that back our Galaxy roles are in some cases widely used, forked and cloned. They all use the implicit naming convention of an ansible-role- prefix.

We have just been hit by having all our roles unexpectedly renamed to use underscores. What do you suggest users like us (and users of our roles) should do to maintain consistent developer and user experiences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment