Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a smoother transition from hyphens to underscores in role names #1128

Closed
oneswig opened this issue Sep 4, 2018 · 1 comment
Closed

Support a smoother transition from hyphens to underscores in role names #1128

oneswig opened this issue Sep 4, 2018 · 1 comment

Comments

@oneswig
Copy link

@oneswig oneswig commented Sep 4, 2018

Feature Request

The Galaxy role server can internally migrate to underscores in role names, but should serve roles for client requests using either hyphens or underscores.

Use Case

In the transition to Galaxy 3.0, a change in naming was introduced that led to the renaming of all our roles from using hyphens to underscores. Without apparent warning this led to all our deploys and CI breaking.

This disruption to us, our clients and the user base of our roles could be avoided if the original name of the role was still treated as valid.

Proposed Solution

These two URLs should translate to retrieve the same object, or be populated with duplicated content to have the same effect:

https://galaxy.ansible.com/stackhpc/os-images
https://galaxy.ansible.com/stackhpc/os_images

Alternatives

Break the world for Galaxy users?

Implementation

Various options here:

  • At the most basic level this may be solvable through URL rewrite rules.
  • If a static document tree is in use, it could be populated at both locations.
  • For dynamic-generated content, a solution within Galaxy's server code should equally be possible.
@chouseknecht
Copy link
Member

@chouseknecht chouseknecht commented Jan 15, 2019

Reiterating what was stated on #779:

As we move toward Mazer and changing the way Ansible content is installed to the local filesystem, path and content names are expected to be Python compatible. So for this reason, we will no longer support '-' in namespace, repository and content names.

For existing Galaxy users, we will continue to allow '-' in one-off cases by performing manual database updates on request. The goal is to not break existing content, and as best we can, help users transition to new names.

If you do run into a case where you need '_' converted to '-', please file an issue, and we'll perform the update as quickly as possible.

Backend automation moved this from To do to Done Jan 15, 2019
tiraboschi added a commit to tiraboschi/ovirt-ansible that referenced this issue Apr 24, 2019
tiraboschi added a commit to tiraboschi/ovirt-ansible that referenced this issue May 30, 2019
machacekondra added a commit to oVirt/ovirt-ansible that referenced this issue May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backend
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.