Add an endpoint to return a CollectionVersion's resolved dependencies #522
Conversation
bmclaughlin
force-pushed
the
enhancement/242-dep-resolution
branch
from
28cd1a2
to
658f973
Compare
- Notes conflicts in returned dictionary Issue: AAH-8
bmclaughlin
force-pushed
the
enhancement/242-dep-resolution
branch
from
658f973
to
bfb1d39
Compare
Issue: AAH-8
bmclaughlin
requested review from
alikins,
awcrosby,
chouseknecht,
cutwater and
newswangerd
as code owners
|
Generally the entire Galaxy API V3 is put into pulp_ansible and then subclassed back to galaxy_ng. Have we considered where the right place to contribute this is? |
| @@ -17,6 +17,8 @@ | |||
| CollectionVersionListSerializer as _CollectionVersionListSerializer, | |||
| ) | |||
|
|
|||
| from pulp_ansible.app.models import CollectionVersion | |||
There was a problem hiding this comment.
PEP8:
Imports should be grouped in the following order:
Standard library imports.
Related third party imports.
Local application/library specific imports.
| from django.http import HttpResponseRedirect, StreamingHttpResponse | ||
| from django.shortcuts import get_object_or_404 | ||
| from django.urls import reverse | ||
|
|
||
| from functools import reduce | ||
| from operator import __and__ as AND |
There was a problem hiding this comment.
Please use operator.and_
https://docs.python.org/3.9/library/operator.html
For backward compatibility, many of these have a variant with the double underscores kept. The variants without the double underscores are preferred for clarity.
| offset = 1 | ||
| operand = d[:offset] | ||
| version = d[offset:] | ||
| if '>=' == operand: |
There was a problem hiding this comment.
You can use the "dispatch dictionary" pattern to replace this if-elif-else construction.
| if resolved_version_number: | ||
| resolved_deps[key] = resolved_version_number | ||
| else: | ||
| resolved_deps[key] = f"Conflict! {deps}" |
There was a problem hiding this comment.
In case of dependency conflict it does not produce an error, but returns formatted string. Could you please give examples of API response format?
There was a problem hiding this comment.
With conflict:
{
"bmclaughlin.conflict2": "0.0.3",
"bmclaughlin.deps2": "Conflict! {'bmclaughlin.deps2': '>0.1.0,<0.1.0'}"
}
Without conflict:
{
"bmclaughlin.deps2": "0.0.3",
"bmclaughlin.deps1": "0.0.4",
"bmclaughlin.execution_env_test": "0.1.2",
"ansible.netcommon": "1.3.0"
}
There was a problem hiding this comment.
Response format in case of conflict is vague and requires parsing on a client.
Can you please give a link to this API format specification?
- operator.and_ usage - dispatch dictionary pattern - corrected import ordering Issue: AAH-8
| if resolved_version_number: | ||
| resolved_deps[key] = resolved_version_number | ||
| else: | ||
| resolved_deps[key] = f"Conflict! {deps}" |
There was a problem hiding this comment.
Response format in case of conflict is vague and requires parsing on a client.
Can you please give a link to this API format specification?
|
No errors: With errors: |
|
We're going to migrate this to pulp_ansible. |
Issue: AAH-8