New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exercise 3 sample yaml #291

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@mk2
Copy link
Contributor

mk2 commented Mar 1, 2018

I have faced some invalid sample yaml codes in exercise 3. So, fixed them.

  1. apache_webserver_port is missing. (but used in the template)
  2. {% raw %} is not needed.

When I have learned ansible by the lightbulb at Redhat JP (Ansible MokuMoku Kai #1), found them. Thanks Redhat JP Experts.

@tima tima requested review from liquidat , tima and dfederlein Mar 6, 2018

@tima tima added guides bug labels Mar 6, 2018

@liquidat
Copy link
Collaborator

liquidat left a comment

Thanks for catching the missing variable. However, the raw tag is still needed for the export to github pages.

@@ -48,22 +48,21 @@ Add a play definition and some variables to your playbook. These include addtio
- mod_wsgi
apache_test_message: This is a test message
apache_max_keep_alive_requests: 115
apache_webserver_port: 80

This comment has been minimized.

@liquidat

liquidat Mar 20, 2018

Collaborator

This is a good catch, thanks!

@@ -175,6 +173,7 @@ Your new, improved playbook is done! Let's take a second look to make sure every
- mod_wsgi
apache_test_message: This is a test message
apache_max_keep_alive_requests: 115
apache_webserver_port: 80

This comment has been minimized.

@liquidat

liquidat Mar 20, 2018

Collaborator

Thanks, this is a good catch as well.

```

### Step 3

Add a new task called *httpd packages are present*:

```yml
{% raw %}

This comment has been minimized.

@liquidat

liquidat Mar 20, 2018

Collaborator

Unfortunately, as of right now we need the {% raw %} tag to be able to export to github pages properly. Without the raw tag, the double curly brackets are not properly formatted.

tasks:
- name: Ensure httpd packages are present
yum:
name: "{{ item }}"
state: present
with_items: "{{ httpd_packages }}"
notify: restart-apache-service
{% endraw %}

This comment has been minimized.

@liquidat

liquidat Mar 20, 2018

Collaborator

Unfortunately, as of right now we need the {% raw %} tag to be able to export to github pages properly. Without the raw tag, the double curly brackets are not properly formatted.

@@ -164,7 +163,6 @@ handlers:
Your new, improved playbook is done! Let's take a second look to make sure everything looks the way you intended. If not, now is the time for us to fix it up. The figure below shows line counts and spacing.

```yml
{% raw %}

This comment has been minimized.

@liquidat

liquidat Mar 20, 2018

Collaborator

Unfortunately, as of right now we need the {% raw %} tag to be able to export to github pages properly. Without the raw tag, the double curly brackets are not properly formatted.

@@ -211,7 +210,6 @@ Your new, improved playbook is done! Let's take a second look to make sure every
service:
name: httpd
state: restarted
{% endraw %}

This comment has been minimized.

@liquidat

liquidat Mar 20, 2018

Collaborator

Unfortunately, as of right now we need the {% raw %} tag to be able to export to github pages properly. Without the raw tag, the double curly brackets are not properly formatted.

@tima

This comment has been minimized.

Copy link
Collaborator

tima commented Mar 21, 2018

@mk2 I agree with @liquidat -- we need those raw tags for (eventually) publishing to Github Pages which we hope to do soon. Please revert those changes in your PR so we can merge the other changes.

@mk2

This comment has been minimized.

Copy link
Contributor

mk2 commented Mar 26, 2018

@tima Thanks reviewing. I have reverted the raw/endraw deletion, and committed.

@tima

This comment has been minimized.

Copy link
Collaborator

tima commented Mar 26, 2018

Thanks for your help @mk2.

@tima tima merged commit e62499c into ansible:master Mar 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

mrjoshuap added a commit to mrjoshuap/lightbulb that referenced this pull request Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment