Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挅 Molecule is looking for additional maintainers #2764

Closed
ssbarnea opened this issue Jul 28, 2020 · 12 comments
Closed

馃挅 Molecule is looking for additional maintainers #2764

ssbarnea opened this issue Jul 28, 2020 · 12 comments
Labels
help wanted proposal Suggestion for a larger change

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Jul 28, 2020

No, I am not leaving anywhere but I want to state that I am seriously looking into enlarging the pool of people that can perform maintenance on molecule itself.

If you are interested please let me know, the most important part is ability and willingness to review PRs and issues.

Ideally no change should be merged without a peer review and sadly during the last few months I was not able to fully respect this as I struggled to get reviews from others. An outcome is that I stopped working on any bugfixes and only reviewed code from others.

I am open to give review permissions quite soon but I also want to mention that I will start removing people with core rights that failed to performed any reviews for a longer period of time.

IMHO, a core developer has a moral duty of trying to review incoming changes. It is perfectly normal for them to remove themself from reviews where they do not know how to review but that does not mean they should be totally passive forever. By doing this we should also make it much easier to pick reviewers, as the dropdown list will have less "ghosts" ;)

Please state your interest here and do not forget that you can already perform reviews, even if you where not invited yet (remember to use the review button from file tab, just a PR comment does not appear as review).

@ssbarnea ssbarnea added proposal Suggestion for a larger change help wanted labels Jul 28, 2020
@decentral1se decentral1se pinned this issue Jul 28, 2020
@ghost
Copy link

ghost commented Jul 28, 2020

I'd like to volunteer to help with reviewing PRs and issues. I don't have a pure developer background, but I know Python and Ansible and use Molecule almost daily.

@greg-hellings
Copy link
Contributor

I would be happy to help with reviews and maintenance work. I'm in and out of Molecule on a daily basis as day.job is Molecule scenarios for Ansible collections

@alainchiasson
Copy link
Contributor

I have been using Molecule on and off since the 2.x switch, and push it anywhere I can. I would love to help out.

@eighty20results
Copy link

I'd be very interested in helping out. Been developing with/for Python, Ansible and Molecule for a little while, for the computer manufacturer I work for and am doing daily code review in that context.

@SteveFroehlich
Copy link

Making an on ramp to being a maintainer might be helpful. For example just creating a new label, like Mozilla does with good first bug, could make it a lot easier for people to know where to start.

@ssbarnea
Copy link
Member Author

ssbarnea commented Oct 1, 2020

I did not seen much success in using a good-first-bug label on other projects, most users lost interest before making a PR and the only result was cluttering the project with extra labels, not to mention that this prevented more senior people from fixing these issues.

If someone wants to help they have two options: randomly pick something and raise a PR or engaging on #ansible-molecule freenode channel. On irc it is much likely to give an instant answer on what can be done to help. Also the channel received notifications regarding any new open issue or pull-request.

@hluaces
Copy link
Contributor

hluaces commented Oct 1, 2020

I could help if needed.

I don't have a full developer background, but I work with Ansible + Molecule daily and I've done a few custom modules for Ansible as well.

@ssbarnea
Copy link
Member Author

ssbarnea commented Oct 1, 2020

@hluaces Thanks. Even watching what happens and reviewing changes can very extremely valuable. Some PRs may need local checkout and manual testing. It is a misconception that only python developers can help.

@hluaces
Copy link
Contributor

hluaces commented Oct 1, 2020

@ssbarnea great, count me in.

@IlyesSemlali
Copy link

Hi @ssbarnea, I'm also volunteer, I can spend at least half an hour a day, taking issues and reviewing code. I've been working on a fix for the 2.20 version, but it was the time the 3.0 version got released.

@decentral1se
Copy link
Contributor

Pop by on #ansible-molecule IRC channel @ freenode folks if you want to discuss / organise / whatever to get things done 馃巻

@ssbarnea ssbarnea unpinned this issue Oct 26, 2020
@sobedrinker42
Copy link

I'll be happy to contribute. limited with python knowledge but work with molecule/ansible daily.

@ssbarnea ssbarnea closed this as completed Jun 5, 2021
@ansible ansible locked and limited conversation to collaborators Jun 5, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
help wanted proposal Suggestion for a larger change
Projects
None yet
Development

No branches or pull requests

9 participants