Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAny chance of Testinfra being bumped to latest? #853
Conversation
This comment has been minimized.
This comment has been minimized.
@rosstimson Looks good. Can you also update all the scenarios in |
This comment has been minimized.
This comment has been minimized.
Sorry I missed those. Hopefully done what you were asking for now. My Python is not great (still learning) and I was a little unsure about the Thanks. |
retr0h
merged commit b4edb56
into
ansible:master
Jun 7, 2017
This comment has been minimized.
This comment has been minimized.
retr0h
added
the
v1.26
label
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rosstimson commentedJun 7, 2017
Any chance Testinfra could be updated to the latest version? The main reason being that 1.6 and onwards introduced New ‘host’ fixture as a replacement for all other fixtures. This makes tests a little nicer to write but also it means that the Testinfra docs now follow this style.
Apologies if there is more to this than what I've done here. I have tested several of my Molecule projects by manually updating Testinfra within the virtualenv and continuing to work without a problem.
I have also tried to run the
tox
test suites although I'm a newbie to that. I seemed to get a single error on each suite (example follows). It seem to be an idempotence test failure and I'm assuming it is unrelated to my change. I've also tried to verify this by doing a completely fresh clone ofmaster
and runningtox
and again I was getting the same failures.Many thanks for Molecule, it is awesome.
Example of test failure: