Bug 1536963 Updates required to work with openshift 0.4.0 #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
approved these changes
Jan 22, 2018
djzager
approved these changes
Jan 22, 2018
|
@jmontleon I think this is the bug you should use https://bugzilla.redhat.com/show_bug.cgi?id=1536963 |
karmab
approved these changes
Jan 22, 2018
djzager
reviewed
Jan 22, 2018
| openshift_config.load_kube_config() | ||
| token = openshift_client.configuration.api_key['authorization'] | ||
| cluster_host = openshift_client.configuration.host | ||
| token = openshift_client.Configuration().get_api_key_with_prefix('authorization') |
There was a problem hiding this comment.
This also exists on line 1092.
There was a problem hiding this comment.
Thanks. Updated the PR message and fixed 1092.
cfchase
approved these changes
Jan 22, 2018
jmontleon
changed the title
dymurray
approved these changes
Jan 23, 2018
dymurray
reviewed
Jan 23, 2018
|
" jmontleon, karimb, dzager: openshift 0.4.0.a1 is now up on pypi, pip install 'openshift==0.4.0.a1' should grab it" I see there is https://pip.pypa.io/en/stable/reference/pip_install/#pre-release-versions for installing pre-release versions. Not sure if there is a way to use that so we don't lock it down to the alpha version forever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to need to wait for this to be available at the least.
jmontleon: just tagged v0.4.0.a1 which should push itself to pypi once the build passes
It's also entirely possible I've missed other places that need updating.