The spacing here and in provision.yml looks weird to me, does this work?

I think chouseknecht has added a lookup module for this, probably a good place to showcase it: https://docs.ansible.com/ansible/devel/plugins/lookup/openshift.html I think ansible also has a jsonquery/path filter built in to it, probably should add the dependency to apb-base since it's pretty useful.

@fabianvf @dymurray I scrapped the use of lookups for verification because they don't work as you would expect and I think this is cleaner and makes more sense. I'll consider writing an issue against Ansible, but for now, I think this is the most correct way to do this.

+1 to how you organized this. Good idea including defaults for what the broker provides

smart, good idea

I think chouseknecht has added a lookup module for this, probably a good place to showcase it: https://docs.ansible.com/ansible/devel/plugins/lookup/openshift.html

^^

seems like state should be set by `apb_action` inside the role

^^

any reason these need to be strings and not bools?

My hope is to have the broker provide the service instance id as `apb_id` instead of `_apb_service_instance_id` (and have `apb_id` passed on all APB actions) to make this work with and w/o a broker. If `_apb_service_instance_id` stays, then I'll change this.

+1 I like this approach a lot

Seems a little overkill to have a whole vars directory for these two 1-line files.

any reason you aren't inlining these?

I think you won't need this anymore, right?