Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hello-world-apb for ansible 2.6 #8

Merged
merged 5 commits into from Jun 4, 2018
Merged

Update hello-world-apb for ansible 2.6 #8

merged 5 commits into from Jun 4, 2018

Conversation

djzager
Copy link
Contributor

@djzager djzager commented May 31, 2018 •
edited

Since hello-world-apb is experimental and using ansible 2.6 with the dynamic client, this PR updates the APB to work with the latest and greatest.

Fixes: #7

@djzager
Copy link
Contributor Author

djzager commented May 31, 2018

@dymurray If you could have a look that would be very helpful.

dymurray
dymurray approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual ACK. This looks familiar as I've reviewed the other 2.6 PRs.

@djzager djzager merged commit aacda7e into ansibleplaybookbundle:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djzager @dymurray