Ansis Brammanis
ansis

  • MapBox
  • Waterloo/DC
  • Joined on Feb 9, 2012

Organizations

@mapbox @modestmaps @osmlab
May 31, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2624
@ansis

Looks good does it make sense to pass -1 as the index for the symbolquads that do not exist in a tile? It might be nice to not need a special val…

May 20, 2016
ansis commented on issue mapbox/mapbox-gl-js#2562
@ansis

I don't think we need to support this.

May 19, 2016
ansis commented on issue mapbox/mapbox-gl-js#2571
@ansis

This looks similar to #2473 which was fixed in #2553

May 19, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2553
@ansis

awesome, thanks for tracking this down!

May 19, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2596
@ansis

What about having VertexArrayObject maintain a map of program names to VAO objects? Yeah, a map would be cleaner. I think it could be better to h…

May 19, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2596
@ansis

Merging this for the currently release is fine The case I'm worried about is that you accidentally use a single vao where you should be using two d…

May 19, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2585
@ansis

Looks great At first I was a bit skeptical about using pragmas. They add an extra layer of abstraction and make you read a bunch of extra files to …

May 19, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2585
@ansis

A bunch of things are already named layer and to me these aren't layers conceptually. I'm not sure I'd say that the icons and text within a single …

May 19, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2585
@ansis

Can the precision qualifiers (lowp, mediump, highp) definitions be moved into the shaders? Maybe something like #pragma mapbox: define(color, lowp)?…

May 19, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2585
@ansis

Can this slice be removed, either by using the a_ version in the shaders or by removing a_ from all the attribute names?

May 19, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2585
@ansis

Can this be moved to a separate .glsl file?

May 18, 2016
ansis opened pull request mapbox/mapbox-gl-js#2294
@ansis
deduplicate vector-tile geometry -> geojson geometry code
1 commit with 4 additions and 45 deletions
May 12, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2560
@ansis

The intersection between people who need to see these warnings and people who are running browsers that don't support WorkerGlobalScope.console is…

May 12, 2016
ansis commented on issue mapbox/mapbox-gl-js#684
@ansis

implementing this: the first part merge the earcut branch #1606 roughly recreate the really old demo branch (example) on top of master. Manually …

May 12, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2550
@ansis

The increased coupling between Style and VertexArrayObject introduced by that solution is undesirable. Yeah, hmm. Or are you suggesting that we…

May 12, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2560
@ansis

This will log warnings once per page instead of once per map. Based on what we log right now this seems ok to me though.

May 12, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2560
@ansis

Should warnings from workers be logged in all browsers by logging them in the main thread? if not, should we remove the warnings?

May 9, 2016
ansis commented on pull request mapbox/mapbox-gl-js#2550
@ansis

I would rather have the style change reset/destroy the related VAOs instead of allowing on-the-fly. The assertions that were removed are important …

May 7, 2016
ansis opened pull request mapbox/mapbox-gl-js#2544
@ansis
fix #2541, scale circles in pitch views
1 commit with 4 additions and 4 deletions
ansis created branch fix-2541 at mapbox/mapbox-gl-js
May 7, 2016
May 7, 2016
@ansis

I've found it pretty useful to have a geojson source and a circle layer on the debug page. The dds circle style was a bit overpowering but I think …

Apr 30, 2016
ansis commented on issue mapbox/mapbox-gl-js#2510
@ansis

I haven't seen any trace of similar behaviour in any of my own projects, where I often have several (up to 10) GeoJSON sources, which at any given…

Apr 29, 2016
ansis commented on issue mapbox/mapbox-gl-js#2510
@ansis

My guess is that this is caused by redrawing the clipping mask for each source. We never check if a source has data that needs to be drawn in that …

Apr 29, 2016
ansis commented on issue mapbox/mapbox-gl-js#2515
@ansis

@nickidlugash where can I find the style and sprite for that image?

Apr 29, 2016
ansis commented on issue mapbox/mapbox-gl-js#2513
@ansis

It would be great if two geojson markerclusters could be included in the same map. Multiple marker clusters can be added by adding multiple geojs…

Apr 29, 2016
ansis commented on issue mapbox/mapbox-gl-js#2515
@ansis

Which icons don't look right? If it's the blue ones with a white border, could it be that the border is just too narrow to render well at that reso…

Apr 29, 2016
@ansis
  • @ansis 41e6e4b
    [core] use a GridIndex for queryRenderedFeatures
Apr 29, 2016
@ansis
  • @ansis 934cbac
    [core] use a GridIndex for queryRenderedFeatures
Apr 29, 2016
@ansis
  • @ansis f8c3331
    [core] use a GridIndex for queryRenderedFeatures
Apr 29, 2016
@ansis