New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values without property length would pass validation #13

Merged
merged 1 commit into from Dec 11, 2014

Conversation

Projects
None yet
3 participants
@Cellule
Copy link
Contributor

Cellule commented Nov 23, 2014

fix bug where value with no length would pass validation with length required

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 23, 2014

Coverage Status

Coverage remained the same when pulling 0f9392d on Cellule:fix_length_bug into a207816 on ansman:master.

@ansman

This comment has been minimized.

Copy link

ansman commented on 0f9392d Dec 11, 2014

I'll merge this but I'm going to introduce a new error specifically for this, thanks

ansman added a commit that referenced this pull request Dec 11, 2014

Merge pull request #13 from Cellule/fix_length_bug
Values without property length would pass validation

@ansman ansman merged commit 711dd59 into ansman:master Dec 11, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@Cellule Cellule deleted the Cellule:fix_length_bug branch Jan 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment