Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dts): add a d.ts and configuration for TS users #140

Merged
merged 1 commit into from Jul 3, 2016

Conversation

@EisenbergEffect
Copy link
Contributor

EisenbergEffect commented Jun 19, 2016

This commit enables TypeScript developers to use this library by
providing the minimal set of type definitions along with configuration
in package.json for the TypeScript compiler and a typings.json file for
popular d.ts acquisition tools.

This commit enables TypeScript developers to use this library by
providing the minimal set of type definitions along with configuration
in package.json for the TypeScript compiler and a typings.json file for
popular d.ts acquisition tools.
@coveralls
Copy link

coveralls commented Jun 19, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 27d04c2 on EisenbergEffect:master into 03862f9 on ansman:master.

@ansman
Copy link
Owner

ansman commented Jun 20, 2016

This seems great. Just a quick question though. Shouldn't all of the public API be exposed like this?

@EisenbergEffect
Copy link
Contributor Author

EisenbergEffect commented Jun 20, 2016

Yes, they should. The Aurelia community is using this plugin a lot. We built a nice validation plugin on top of it but we had a lot of issues with TS users who couldn't get the d.ts file. So, I just wanted to put something basic in place that would at least satisfy the main-use APIs.

@ansman ansman merged commit 8104e7e into ansman:master Jul 3, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ansman
Copy link
Owner

ansman commented Nov 5, 2016

Released in 0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.