New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type definition #185

Merged
merged 1 commit into from Jun 25, 2017

Conversation

Projects
None yet
6 participants
@jkeylu
Contributor

jkeylu commented Dec 9, 2016

No description provided.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 9, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 2a8d3aa on jkeylu:master into ab5ad5a on ansman:master.

coveralls commented Dec 9, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 2a8d3aa on jkeylu:master into ab5ad5a on ansman:master.

@mrkmg

This comment has been minimized.

Show comment
Hide comment
@mrkmg

mrkmg Mar 20, 2017

@ansman please consider this, as right now using this library in typescript projects is troublesome.

mrkmg commented Mar 20, 2017

@ansman please consider this, as right now using this library in typescript projects is troublesome.

@justrhysism

This comment has been minimized.

Show comment
Hide comment
@justrhysism

justrhysism Jun 6, 2017

Is there any reason this PR hasn't been approved?

justrhysism commented Jun 6, 2017

Is there any reason this PR hasn't been approved?

@skellock

This comment has been minimized.

Show comment
Hide comment
@skellock

skellock Jun 16, 2017

Sorry, don't mean to +1 this, so I'll add a bit more content to pretend this comment isn't that.

The types in current release aren't quite right. The ones in @types/validatejs aren't quite right either. These look great.

Any chance we could sneak this PR in? Anything I could do to help?

skellock commented Jun 16, 2017

Sorry, don't mean to +1 this, so I'll add a bit more content to pretend this comment isn't that.

The types in current release aren't quite right. The ones in @types/validatejs aren't quite right either. These look great.

Any chance we could sneak this PR in? Anything I could do to help?

@ansman ansman merged commit 70dd12d into ansman:master Jun 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment