This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Added Support for Syncronous Testing of Promise Presence#221
Closed
bbusschots-mu wants to merge 1 commit intoansman:masterfrom
Closed
Added Support for Syncronous Testing of Promise Presence#221bbusschots-mu wants to merge 1 commit intoansman:masterfrom
bbusschots-mu wants to merge 1 commit intoansman:masterfrom
Conversation
While the resolution of a promise is clearly an asynchronous thing, testing for the presence of a promise is not, so it should be possible to test if a given value is a promise using `validate()` or `validate.single()`. This very small commit makes that possible by adding an option `allowPromises` to `validate()`.
Owner
|
This has actually been a long standing bug. |
Owner
|
Closed via bfa56eb |
Owner
|
A fix has been released in 0.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the resolution of a promise is clearly an asynchronous thing, testing for the presence of a promise is not, so it should be possible to test whether or not a given value is a promise using
validate()orvalidate.single().This very small commit makes that possible by adding an option
allowPromisestovalidate().The following console output from
noderun from the project root folder shows the proposed change in action:I could also add the
promisevalidator as a separate pull request?