This repository was archived by the owner on Dec 12, 2021. It is now read-only.
feature: make a best guess at prettifying object that have no prototype #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm working with a third party library that initializes objects using
Object.create(null)(graphql). The result is that these objects do not have prototypes and do not implementtoString. This becomes an issue when trying to validate object using your (otherwise wonderful) library.I have added a line that checks whether a given object implements
toStringand tries to fall back onJSON.stringify. Ifstringifyencounters the dreaded cyclic structure, then at that point I would say maybe the user needs to rethink things.I've added two tests to capture this new behaviour. I think that this is not a breaking change. Please let me know if you have any questions or feedback!
For some background on this issue, see discussion here: graphql/express-graphql#177