This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Allow custom messages on numericality options object for each validation#35
Merged
ansman merged 1 commit intoansman:masterfrom Oct 10, 2015
Merged
Allow custom messages on numericality options object for each validation#35ansman merged 1 commit intoansman:masterfrom
ansman merged 1 commit intoansman:masterfrom
Conversation
…for each validation
ansman
changed the title
Owner
|
I'm sorry I haven't responded to this yet, it must be slipped between my fingers. I'll review this ASAP, it sounds like a reasonable request. |
ansman
added a commit
that referenced
this pull request
Oct 10, 2015
Allow custom messages on numericality options object for each validation
ansman
added a commit
that referenced
this pull request
Oct 10, 2015
Owner
|
Released in 0.9.0 and again, sorry for the extremely long waiting time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the same way that I am able to custom validation messages to the length validator options object - for example: (wrongLength, tooLong, tooShort) - I want to add custom messages on the options object to the of numericality validator.
validate.validators.numericality.notGreaterThan sets a default value. I need a custom message which is different for the same validations (numericality, greater than X) but with a completely different message.
Include changes to numericality-spec.js
Totally up for providing examples and text for validate.js documentation if desired.