This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Fixed missing support for fullMessages: false in validate.async #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ansman Hi! When are you going to merge this pull request? |
ansman
added a commit
that referenced
this pull request
Dec 11, 2014
Fixed missing support for fullMessages: false in validate.async
|
Shit, sorry about this. For some reason I haven't been getting notified about new PRs and issues. Thanks for fixing this. |
ansman
added a commit
that referenced
this pull request
Dec 11, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The
optionswere never passed intoprocessValidationResults, where it checks whether thefullMessagesflag has been set tofalse.