Updating protos and adding V0 version #3
Conversation
| option go_package = "google.golang.org/genproto/googleapis/api/annotations;annotations"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "AnnotationsProto"; | ||
| option java_package = "com.google.api"; | ||
| option objc_class_prefix = "GAPI"; |
There was a problem hiding this comment.
Do we need all those options.
For an other projects, we were not using them. Just checking.
There was a problem hiding this comment.
I'd probably leave them for now. Just in case they need them. But I will ask the Discovery team. This may take some time to clarify.
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
|
Thanks for the quick review @MaxJPRey! Due to pressing circumstances (I'd like to try out if the package works, and thus make a release), I am going to merge this PR. If you have any further comments, please make them. I will add them in a second-round PR. Thanks for your time! --> I will include those changes as a patch in the release branch as well, no worries =) |
|
Sure, I understand. It makes sense. |
Thanks @MaxJPRey!! |
This task basically consists on generating one same package for different API versions. All versions are compiled and generated as part of the package. End user libraries may then have the ability to select between versions