Feat: Customizing 404 page #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
enhancement
MaxJPRey
reviewed
Nov 9, 2022
MaxJPRey
reviewed
Nov 9, 2022
MaxJPRey
reviewed
Nov 9, 2022
MaxJPRey
reviewed
Nov 9, 2022
RobPasMue
reviewed
Nov 10, 2022
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
See my suggestions above. I'd change the way generate_404 is called (and its arguments)
jorgepiloto
requested changes
Nov 10, 2022
Revathyvenugopal162
requested review from
MaxJPRey,
RobPasMue and
jorgepiloto
RobPasMue
approved these changes
Nov 10, 2022
MaxJPRey
reviewed
Nov 10, 2022
MaxJPRey
approved these changes
Nov 10, 2022
Contributor
MaxJPRey
left a comment
MaxJPRey
left a comment
There was a problem hiding this comment.
Excellent improvement @Revathyvenugopal162 that will benefit all the teams.
Thanks for the thorough review @RobPasMue and @jorgepiloto .
Member
|
Merging since it's ready =) |
Revathyvenugopal162
added a commit
that referenced
this pull request
Nov 28, 2022
* Add initail commit for 404 page * Precommit fix * Add docstrings * Appy code suggestion * Improve docs strings * Update src/ansys_sphinx_theme/latex/__init__.py Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customized 404 page.