From 825315f77c82ed0d09d362ee1f4b271707b38087 Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Mon, 21 Apr 2025 09:36:19 +0200 Subject: [PATCH 1/3] fix: pyvista read-only behaviour --- .../backends/pyvista/pyvista_interface.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py b/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py index 7fe32b7e..45f90166 100644 --- a/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py +++ b/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py @@ -180,7 +180,11 @@ def clip( Clipped mesh. """ - return mesh.clip(normal=plane.normal, origin=plane.origin) + # Make sure to pass new copies/objects to the mesh for the normal + # This should be fixed by PyVista eventually... it is coming from + # https://github.com/RobPasMue/pyvista/commit/2db1888a294a14e4f28a140d8aa0466d332912dc + return mesh.clip(normal=[elem for elem in plane.normal], + origin=plane.origin) def plot_meshobject(self, custom_object: MeshObjectPlot, **plotting_options): """Plot a generic ``MeshObjectPlot`` object to the scene. From 2bec3c3dfb2f111e76e34ad63d129bfd52702f3c Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Mon, 21 Apr 2025 09:47:50 +0200 Subject: [PATCH 2/3] Update pyvista_interface.py --- .../backends/pyvista/pyvista_interface.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py b/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py index 45f90166..3a67d35b 100644 --- a/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py +++ b/src/ansys/tools/visualization_interface/backends/pyvista/pyvista_interface.py @@ -182,7 +182,7 @@ def clip( """ # Make sure to pass new copies/objects to the mesh for the normal # This should be fixed by PyVista eventually... it is coming from - # https://github.com/RobPasMue/pyvista/commit/2db1888a294a14e4f28a140d8aa0466d332912dc + # https://github.com/pyvista/pyvista/commit/2db1888a294a14e4f28a140d8aa0466d332912dc return mesh.clip(normal=[elem for elem in plane.normal], origin=plane.origin) From 83835a86ac92b5d1fb0db3506d176639c736351a Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Mon, 21 Apr 2025 07:48:48 +0000 Subject: [PATCH 3/3] chore: adding changelog file 281.fixed.md [dependabot-skip] --- doc/changelog.d/281.fixed.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/281.fixed.md diff --git a/doc/changelog.d/281.fixed.md b/doc/changelog.d/281.fixed.md new file mode 100644 index 00000000..062cdcda --- /dev/null +++ b/doc/changelog.d/281.fixed.md @@ -0,0 +1 @@ +fix: pyvista read-only behaviour \ No newline at end of file