From 4f9ea3c0ee85f2c0cefd1271ca98b9a93e90fb77 Mon Sep 17 00:00:00 2001 From: Alex Fernandez Luces Date: Mon, 6 Oct 2025 16:44:13 +0200 Subject: [PATCH 1/3] fix: Uninitialized variable in PyVistaBackendInterface --- .../visualization_interface/backends/pyvista/pyvista.py | 2 ++ tests/test_generic_plotter.py | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py b/src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py index 1154d3d5..13640b5d 100644 --- a/src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py +++ b/src/ansys/tools/visualization_interface/backends/pyvista/pyvista.py @@ -131,6 +131,8 @@ def __init__( # Map that relates PyVista actors with PyAnsys objects self._object_to_actors_map = {} + self._edge_actors_map: Dict[pv.Actor, EdgePlot] = {} + # PyVista plotter self._pl = None diff --git a/tests/test_generic_plotter.py b/tests/test_generic_plotter.py index 6e50b64e..dc7c063f 100644 --- a/tests/test_generic_plotter.py +++ b/tests/test_generic_plotter.py @@ -27,7 +27,7 @@ import pytest import pyvista as pv -from ansys.tools.visualization_interface import ClipPlane, MeshObjectPlot, Plotter +from ansys.tools.visualization_interface import ClipPlane, MeshObjectPlot, EdgePlot, Plotter from ansys.tools.visualization_interface.backends.pyvista import PyVistaBackend from ansys.tools.visualization_interface.backends.pyvista.picker import Picker @@ -93,7 +93,9 @@ def test_plotter_add_structured_grid(): def test_plotter_add_custom(): """Adds a MeshObjectPlot object to the plotter.""" sphere = pv.Sphere() - custom = MeshObjectPlot(CustomTestClass("myname"), sphere) + edge = pv.Cube((0, 1, 0)) + custom_edge = EdgePlot(CustomTestClass("myname_edge"), edge) + custom = MeshObjectPlot(CustomTestClass("myname"), sphere, edges=[custom_edge]) pl = Plotter() pl.plot(custom) pl.show() From 0b7e807625055d27376e938f8d815523c81e93df Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 6 Oct 2025 14:45:10 +0000 Subject: [PATCH 2/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- tests/test_generic_plotter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_generic_plotter.py b/tests/test_generic_plotter.py index dc7c063f..1377321c 100644 --- a/tests/test_generic_plotter.py +++ b/tests/test_generic_plotter.py @@ -27,7 +27,7 @@ import pytest import pyvista as pv -from ansys.tools.visualization_interface import ClipPlane, MeshObjectPlot, EdgePlot, Plotter +from ansys.tools.visualization_interface import ClipPlane, EdgePlot, MeshObjectPlot, Plotter from ansys.tools.visualization_interface.backends.pyvista import PyVistaBackend from ansys.tools.visualization_interface.backends.pyvista.picker import Picker From ccf6ed11a8ec2adebc9dea856b97735cfd2f0a0f Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Mon, 6 Oct 2025 14:46:25 +0000 Subject: [PATCH 3/3] chore: adding changelog file 375.miscellaneous.md [dependabot-skip] --- doc/changelog.d/375.miscellaneous.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/375.miscellaneous.md diff --git a/doc/changelog.d/375.miscellaneous.md b/doc/changelog.d/375.miscellaneous.md new file mode 100644 index 00000000..447faeef --- /dev/null +++ b/doc/changelog.d/375.miscellaneous.md @@ -0,0 +1 @@ +Fix: Uninitialized variable in PyVistaBackendInterface