Support 24/12 Eco BoM#693
Merged
Merged
Conversation
Andy-Grigg
commented
Jan 31, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 97.64% 97.76% +0.11%
==========================================
Files 24 28 +4
Lines 2591 3038 +447
==========================================
+ Hits 2530 2970 +440
- Misses 61 68 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…m/ansys/grantami-bomanalytics into feat/force-strict-deserialization
75cb128 to
dd79fef
Compare
dd79fef to
683335f
Compare
This was referenced Feb 12, 2025
683335f to
08f7681
Compare
08f7681 to
57c8e62
Compare
Collaborator
Author
|
The first example test sometimes times out. I'll try upgrading, see if that fixes it. |
Andy-Grigg
commented
Feb 14, 2025
Collaborator
Author
|
Since we've converted the reader and writer classes to generics, we could define the BoMHandler class itself as a generic instead. It's a choice between whether we want to make the user decide ahead of time which version BoM version they want to work with or not. |
ludovicsteinbach
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #689
eco2412submodule for the 24/12 eco schema.bom_helpersubmodule to be able to handle different BoMs with different namespaces. Any supported BoM can be loaded and dumped, and a BoM can be converted to a different namespaceThis is part of a series of 3 PRs: