REFACTOR: Improve API and security in Desktop#5892
Merged
Samuelopez-ansys merged 27 commits intomainfrom Apr 1, 2025
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (78.57%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5892 +/- ##
==========================================
+ Coverage 85.10% 85.11% +0.01%
==========================================
Files 165 165
Lines 62807 62812 +5
==========================================
+ Hits 53449 53461 +12
+ Misses 9358 9351 -7 🚀 New features to boost your workflow:
|
MaxJPRey
reviewed
Mar 11, 2025
MaxJPRey
previously approved these changes
Mar 17, 2025
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
SMoraisAnsys
commented
Mar 28, 2025
Collaborator
Author
|
@Samuelopez-ansys @maxcapodi78 This is ready :) |
Samuelopez-ansys
previously approved these changes
Mar 31, 2025
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
Samuelopez-ansys
previously approved these changes
Apr 1, 2025
Samuelopez-ansys
approved these changes
Apr 1, 2025
Samuelopez-ansys
approved these changes
Apr 1, 2025
Samuelopez-ansys
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR consist in a refactoring of the desktop module to clean it and strengthen the calls related to subprocess. On top of that, a new section has been added to the documentation to notify about the risk of using insecure commands.
Changes are:
__method instead of_method when it makes sense;Issue linked
#5504
Checklist