Skip to content

FEAT: Improve circuit wire methods#5904

Merged
Samuelopez-ansys merged 11 commits into
mainfrom
improve_circuit
Mar 13, 2025
Merged

FEAT: Improve circuit wire methods#5904
Samuelopez-ansys merged 11 commits into
mainfrom
improve_circuit

Conversation

@maxcapodi78
Copy link
Copy Markdown
Collaborator

Description

New methods in Wire class of Circuit. get_net_name and set_net_name
Additionally corrected the page_port creation.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 85.10638% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (d444628) to head (1e4fa30).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5904      +/-   ##
==========================================
- Coverage   85.01%   84.96%   -0.05%     
==========================================
  Files         161      161              
  Lines       62214    62248      +34     
==========================================
  Hits        52889    52889              
- Misses       9325     9359      +34     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 13, 2025 16:53
@Samuelopez-ansys Samuelopez-ansys merged commit 5465db7 into main Mar 13, 2025
@Samuelopez-ansys Samuelopez-ansys deleted the improve_circuit branch March 13, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants