Skip to content

FEAT: circuit configuration#5920

Merged
Samuelopez-ansys merged 10 commits intomainfrom
circuit_config
Mar 24, 2025
Merged

FEAT: circuit configuration#5920
Samuelopez-ansys merged 10 commits intomainfrom
circuit_config

Conversation

@gkorompi
Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gkorompi gkorompi linked an issue Mar 15, 2025 that may be closed by this pull request
@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 15, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 115 lines in your changes missing coverage. Please review.

Project coverage is 84.85%. Comparing base (ac19ba5) to head (9fddc09).
Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (44.44%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5920      +/-   ##
==========================================
- Coverage   85.00%   84.85%   -0.15%     
==========================================
  Files         162      162              
  Lines       62374    62542     +168     
==========================================
+ Hits        53019    53072      +53     
- Misses       9355     9470     +115     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hui-zhou-a
Copy link
Copy Markdown
Contributor

@gkorompi could you add test?

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 24, 2025 12:36
@Samuelopez-ansys Samuelopez-ansys merged commit e9b07b2 into main Mar 24, 2025
46 of 47 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the circuit_config branch March 24, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circuit Configuration

5 participants