Skip to content

FIX: Prevent solution invalidation in create_fieldplot_volume - #5922

Merged
lorenzovecchietti merged 3 commits into
mainfrom
fix/issue_5921
Mar 18, 2025
Merged

FIX: Prevent solution invalidation in create_fieldplot_volume#5922
lorenzovecchietti merged 3 commits into
mainfrom
fix/issue_5921

Conversation

@lorenzovecchietti

Copy link
Copy Markdown
Contributor

Close #5921

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label Mar 17, 2025
@lorenzovecchietti lorenzovecchietti changed the title Use undo instead of delete, so that solution is not invalidated. FIX: Prevent solution invalidation in create_fieldplot_volume Mar 18, 2025
@codecov

codecov Bot commented Mar 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (f52eb6c) to head (c51cad6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5922      +/-   ##
==========================================
+ Coverage   82.20%   84.95%   +2.75%     
==========================================
  Files         162      162              
  Lines       62305    62305              
==========================================
+ Hits        51216    52931    +1715     
+ Misses      11089     9374    -1715     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenzovecchietti
lorenzovecchietti merged commit 0d1055f into main Mar 18, 2025
@lorenzovecchietti
lorenzovecchietti deleted the fix/issue_5921 branch March 18, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in create_fieldplot_volume

3 participants