Skip to content

FIX: issue 5864. Solve inside ON for Network objects - #5923

Merged
Samuelopez-ansys merged 2 commits into
mainfrom
fix/issue_5864
Mar 18, 2025
Merged

FIX: issue 5864. Solve inside ON for Network objects #5923
Samuelopez-ansys merged 2 commits into
mainfrom
fix/issue_5864

Conversation

@siva-krishnaswamy

@siva-krishnaswamy siva-krishnaswamy commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

No need to set the material for network block. Setting the material will turn on solve inside which will deactivate the network boundary condition.

Close #5864

Description

removed

self.modeler.primitives[object_name].material_name = "Ceramic_material"

not necessary

Issue linked

issue 5864

Checklist

  • [ x] I have tested my changes locally.
  • [ x] I have added necessary documentation or updated existing documentation.
  • [x ] I have followed the coding style guidelines of this project.
  • [x ] I have added appropriate tests (unit, integration, system).
  • [x ] I have reviewed my changes before submitting this pull request.
  • [x ] I have linked the issue or issues that are solved by the PR if any.
  • [ x] I have agreed with the Contributor License Agreement (CLA).

…tting the material will turn on solve inside which will deactivate the network boundary condition.
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label Mar 18, 2025
@siva-krishnaswamy siva-krishnaswamy linked an issue Mar 18, 2025 that may be closed by this pull request
2 tasks
@siva-krishnaswamy siva-krishnaswamy changed the title fix for issue 5864. FIX: issue 5864. Solve inside ON for Network objects Mar 18, 2025
@codecov

codecov Bot commented Mar 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.94%. Comparing base (f52eb6c) to head (ab90527).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5923      +/-   ##
==========================================
+ Coverage   82.20%   84.94%   +2.74%     
==========================================
  Files         162      162              
  Lines       62305    62304       -1     
==========================================
+ Hits        51216    52925    +1709     
+ Misses      11089     9379    -1710     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lorenzovecchietti

Copy link
Copy Markdown
Contributor

LGTM
Thanks for catching that!

@Samuelopez-ansys
Samuelopez-ansys merged commit b2ae1d1 into main Mar 18, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the fix/issue_5864 branch March 18, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in solve inside attribute in Icepak.

4 participants