Skip to content

REFACTOR: add arg coefficient in core loss mat#5939

Merged
Samuelopez-ansys merged 6 commits into
mainfrom
fix/set_core_loss_coeff
Mar 24, 2025
Merged

REFACTOR: add arg coefficient in core loss mat#5939
Samuelopez-ansys merged 6 commits into
mainfrom
fix/set_core_loss_coeff

Conversation

@gmalinve

Copy link
Copy Markdown
Contributor

Description

Add a new argument to get_core_loss to be able to setup coefficient

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@gmalinve gmalinve self-assigned this Mar 21, 2025
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Mar 21, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions Bot added the bug Something isn't working label Mar 21, 2025
@gmalinve gmalinve changed the title add arg coefficient in core loss mat REFACTOR: add arg coefficient in core loss mat Mar 21, 2025
@codecov

codecov Bot commented Mar 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (ac19ba5) to head (0ba2930).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5939      +/-   ##
==========================================
- Coverage   85.00%   84.99%   -0.01%     
==========================================
  Files         162      162              
  Lines       62374    62374              
==========================================
- Hits        53019    53017       -2     
- Misses       9355     9357       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SMoraisAnsys
SMoraisAnsys previously approved these changes Mar 22, 2025

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment

Comment thread src/ansys/aedt/core/modules/material.py Outdated
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 24, 2025 08:15

@MaxJPRey MaxJPRey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys merged commit 0ce160e into main Mar 24, 2025
@Samuelopez-ansys Samuelopez-ansys deleted the fix/set_core_loss_coeff branch March 24, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in set_coreloss_at_frequency

5 participants