Skip to content

REFACTOR: pathlib refactor multi-files - #5943

Merged
jvela018 merged 17 commits into
mainfrom
pathlib-refactor-multi-files-1
Mar 26, 2025
Merged

REFACTOR: pathlib refactor multi-files #5943
jvela018 merged 17 commits into
mainfrom
pathlib-refactor-multi-files-1

Conversation

@anur7

@anur7 anur7 commented Mar 24, 2025

Copy link
Copy Markdown
Contributor

Description

Pathlib refactor of multiple files: maxwellcircuit.py, object_3d.py, q3d.py, test_36_Q2D_Postprocessing.py, modeler_pcb.py

Issue linked

issue #5180

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@anur7 anur7 added the enhancement New features or code improvements label Mar 24, 2025
@anur7 anur7 self-assigned this Mar 24, 2025
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov

codecov Bot commented Mar 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.00%. Comparing base (10d9716) to head (94fafb9).
Report is 18 commits behind head on main.

❌ Your patch status has failed because the patch coverage (67.85%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5943      +/-   ##
==========================================
- Coverage   85.01%   85.00%   -0.01%     
==========================================
  Files         162      162              
  Lines       62603    62603              
==========================================
- Hits        53219    53215       -4     
- Misses       9384     9388       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaveTwyman
DaveTwyman marked this pull request as ready for review March 24, 2025 17:38
@DaveTwyman

Copy link
Copy Markdown
Contributor

Sorry this isn't my PR, opened the wrong one and clicked Update Branch and Marked as ready for review, Sorry

@anur7
anur7 marked this pull request as draft March 24, 2025 20:04
@anur7
anur7 marked this pull request as ready for review March 25, 2025 09:15

@jvela018 jvela018 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvela018
jvela018 merged commit 7c8ba0b into main Mar 26, 2025
@jvela018
jvela018 deleted the pathlib-refactor-multi-files-1 branch March 26, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants