Skip to content

REFACTOR: Remove aedt threading#5945

Merged
SMoraisAnsys merged 3 commits into
mainfrom
remove_aedt_threading
Mar 26, 2025
Merged

REFACTOR: Remove aedt threading#5945
SMoraisAnsys merged 3 commits into
mainfrom
remove_aedt_threading

Conversation

@maxcapodi78

Copy link
Copy Markdown
Member

Description

Improve security of launch_aedt method by removing threading and os.environment collect and assignment.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@maxcapodi78 maxcapodi78 changed the title REFACT: Remove aedt threading REFACTOR: Remove aedt threading Mar 24, 2025
@codecov

codecov Bot commented Mar 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.88%. Comparing base (ac19ba5) to head (b21d782).
Report is 28 commits behind head on main.

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5945      +/-   ##
==========================================
- Coverage   85.00%   84.88%   -0.13%     
==========================================
  Files         162      162              
  Lines       62374    62502     +128     
==========================================
+ Hits        53019    53052      +33     
- Misses       9355     9450      +95     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxcapodi78 @Samuelopez-ansys How do we proceed with that PR ? Should we merge it or does it require extra changes ?
I left a minor comment.

Comment thread src/ansys/aedt/core/desktop.py
@SMoraisAnsys SMoraisAnsys merged commit 971c79b into main Mar 26, 2025
@SMoraisAnsys SMoraisAnsys deleted the remove_aedt_threading branch March 26, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants