Skip to content

FIX: Modify SolveSetup for Parametrics#5948

Merged
DaveTwyman merged 4 commits into
mainfrom
5872-analyze_setup-blocking-argument-does-not-work-with-parametrics
Mar 25, 2025
Merged

FIX: Modify SolveSetup for Parametrics#5948
DaveTwyman merged 4 commits into
mainfrom
5872-analyze_setup-blocking-argument-does-not-work-with-parametrics

Conversation

@DaveTwyman
Copy link
Copy Markdown
Contributor

-This enables parametric solves to start solving in parallel and not block the execution of the PyAEDT script

Description

Added use of 'blocking' attribute to ooptimetrics.SolveSetup.

Issue linked

5872 Analyze Setup Blocking Argument does not work with Parametrics

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

-This enables parallel parametrics solves to start.
@DaveTwyman DaveTwyman self-assigned this Mar 24, 2025
@DaveTwyman DaveTwyman linked an issue Mar 24, 2025 that may be closed by this pull request
2 tasks
@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@DaveTwyman DaveTwyman changed the title Modify SolveSetup for Parametrics FIX: Modify SolveSetup for Parametrics Mar 24, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (f37f0eb) to head (86c3c3f).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5948      +/-   ##
==========================================
- Coverage   84.87%   84.86%   -0.01%     
==========================================
  Files         162      162              
  Lines       62548    62548              
==========================================
- Hits        53085    53081       -4     
- Misses       9463     9467       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaveTwyman DaveTwyman requested a review from gmalinve March 24, 2025 17:01
@DaveTwyman DaveTwyman enabled auto-merge (squash) March 24, 2025 18:08
@DaveTwyman DaveTwyman merged commit 282d01b into main Mar 25, 2025
@DaveTwyman DaveTwyman deleted the 5872-analyze_setup-blocking-argument-does-not-work-with-parametrics branch March 25, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

analyze_setup blocking argument does not work with parametrics

3 participants