FEAT: Ibis reader - #5954
Merged
Merged
Conversation
added 3 commits
March 25, 2025 08:37
refactored ConfigurationsNexxim to support variables and the new Ibis models.
refactored ConfigurationsNexxim to support variables and the new Ibis models.
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (81.81%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5954 +/- ##
==========================================
+ Coverage 84.87% 85.00% +0.13%
==========================================
Files 162 162
Lines 62548 62603 +55
==========================================
+ Hits 53085 53214 +129
+ Misses 9463 9389 -74 🚀 New features to boost your workflow:
|
added 3 commits
March 25, 2025 15:00
refactored ConfigurationsNexxim to support variables and the new Ibis models.
refactored ConfigurationsNexxim to support variables and the new Ibis models.
Samuelopez-ansys
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refactored IbisReader to read the correct pin and buffer names
added variables and setup to ConfigurationsNexxim
added mirroring to components
filtering properties before applying values
added another with IBIS and IBIS AMI
fix problem with pin mapping when no connection is present
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist