Skip to content

FEAT: Ibis reader - #5954

Merged
maxcapodi78 merged 7 commits into
mainfrom
refactor_ibis_reader
Mar 25, 2025
Merged

FEAT: Ibis reader#5954
maxcapodi78 merged 7 commits into
mainfrom
refactor_ibis_reader

Conversation

@maxcapodi78

@maxcapodi78 maxcapodi78 commented Mar 25, 2025

Copy link
Copy Markdown
Member

Description

refactored IbisReader to read the correct pin and buffer names
added variables and setup to ConfigurationsNexxim
added mirroring to components
filtering properties before applying values
added another with IBIS and IBIS AMI
fix problem with pin mapping when no connection is present

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

mcapodif added 3 commits March 25, 2025 08:37
refactored ConfigurationsNexxim to support variables and the new Ibis models.
refactored ConfigurationsNexxim to support variables and the new Ibis models.
@maxcapodi78
maxcapodi78 requested a review from gkorompi March 25, 2025 13:34
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov

codecov Bot commented Mar 25, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 81.81818% with 24 lines in your changes missing coverage. Please review.

Project coverage is 85.00%. Comparing base (f37f0eb) to head (19f1b4d).
Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (81.81%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5954      +/-   ##
==========================================
+ Coverage   84.87%   85.00%   +0.13%     
==========================================
  Files         162      162              
  Lines       62548    62603      +55     
==========================================
+ Hits        53085    53214     +129     
+ Misses       9463     9389      -74     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcapodif added 3 commits March 25, 2025 15:00
refactored ConfigurationsNexxim to support variables and the new Ibis models.
refactored ConfigurationsNexxim to support variables and the new Ibis models.
@maxcapodi78
maxcapodi78 merged commit 0701b6c into main Mar 25, 2025
@maxcapodi78
maxcapodi78 deleted the refactor_ibis_reader branch March 25, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants