Skip to content

REFACTOR: Improve code quality and handling of subprocess calls#5995

Merged
SMoraisAnsys merged 12 commits into
mainfrom
refact/improve-code-and-handle-subprocess-calls
Apr 9, 2025
Merged

REFACTOR: Improve code quality and handling of subprocess calls#5995
SMoraisAnsys merged 12 commits into
mainfrom
refact/improve-code-and-handle-subprocess-calls

Conversation

@SMoraisAnsys
Copy link
Copy Markdown
Collaborator

@SMoraisAnsys SMoraisAnsys commented Apr 2, 2025

Description

Improve code quality, avoid bad practices and improve vulnerability risks associated to the use of subprocess.
Note that an static internal method has been removed as I though it was not used/leveraged.

@ansAFinney Part of the changes remove what you did in #4294. Indeed, launching the server and exposing it to all network interfaces is a security risk so it shouldn't be the default behavior. If you want to keep the previous behavior, this is possible using
the AEDT_HOST environment variable.

Associated to #5504

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys changed the title Refact/improve code and handle subprocess calls REFACTOR: Improve code quality and handling of subprocess calls Apr 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (8ae564c) to head (2144281).
Report is 13 commits behind head on main.

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5995      +/-   ##
==========================================
+ Coverage   85.07%   85.09%   +0.02%     
==========================================
  Files         165      165              
  Lines       62892    62886       -6     
==========================================
+ Hits        53505    53514       +9     
+ Misses       9387     9372      -15     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SMoraisAnsys SMoraisAnsys merged commit c25dda9 into main Apr 9, 2025
@SMoraisAnsys SMoraisAnsys deleted the refact/improve-code-and-handle-subprocess-calls branch April 9, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants