Skip to content

BUILD: Update install targets and dependencies#5997

Merged
SMoraisAnsys merged 6 commits into
mainfrom
refactor/install-targets
Apr 3, 2025
Merged

BUILD: Update install targets and dependencies#5997
SMoraisAnsys merged 6 commits into
mainfrom
refactor/install-targets

Conversation

@SMoraisAnsys

@SMoraisAnsys SMoraisAnsys commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

Description

Update install targets by:

  • removing installer target (this target was added at the begining to only install pyaedt but later evolved into something close to all)
  • updating all target with jupyter related dependencies
  • adding examples target install (copy of the pyaedt-examples requirements)

Also, some clean up has been performed where installer was used and backward compatibility has been added for the version extension.

Note

Once merged, pyaedt-examples requirements should evolve to use the examples target.

Issue linked

Associated to #5978

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the maintenance Package and maintenance related label Apr 2, 2025
@codecov

codecov Bot commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (a8ec659) to head (1ae05aa).
Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5997      +/-   ##
==========================================
- Coverage   85.07%   85.06%   -0.02%     
==========================================
  Files         165      165              
  Lines       62879    62893      +14     
==========================================
+ Hits        53493    53498       +5     
- Misses       9386     9395       +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaxJPRey MaxJPRey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys merged commit fe52ee3 into main Apr 3, 2025
@SMoraisAnsys SMoraisAnsys deleted the refactor/install-targets branch April 3, 2025 06:57
@SMoraisAnsys SMoraisAnsys self-assigned this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants