FIX: adding missing argument for 2d electrostatic balloon BC - #6011
Merged
Conversation
anur7
requested review from
SMoraisAnsys,
Samuelopez-ansys,
gmalinve,
maxcapodi78 and
nunesanderson
April 4, 2025 13:32
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
2 tasks
anur7
marked this pull request as ready for review
April 4, 2025 13:32
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6011 +/- ##
==========================================
+ Coverage 82.36% 85.06% +2.70%
==========================================
Files 166 166
Lines 62978 62980 +2
==========================================
+ Hits 51870 53574 +1704
+ Misses 11108 9406 -1702 🚀 New features to boost your workflow:
|
gmalinve
requested changes
Apr 4, 2025
Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
SMoraisAnsys
reviewed
Apr 5, 2025
Samuelopez-ansys
requested changes
Apr 7, 2025
gmalinve
reviewed
Apr 7, 2025
Samuelopez-ansys
approved these changes
Apr 7, 2025
Samuelopez-ansys
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks @anur7 !
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Maxwell Electrostatic solver, balloon boundary condition has 2 types: voltage and charge. In this PR an argument is added in assign_balloon() to set voltage or charge boundary condition type.
Issue linked
Issue #5991
Checklist