Skip to content

FIX: adding missing argument for 2d electrostatic balloon BC - #6011

Merged
anur7 merged 6 commits into
mainfrom
fix-bug-electrostatic-balloon
Apr 7, 2025
Merged

FIX: adding missing argument for 2d electrostatic balloon BC#6011
anur7 merged 6 commits into
mainfrom
fix-bug-electrostatic-balloon

Conversation

@anur7

@anur7 anur7 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Description

In Maxwell Electrostatic solver, balloon boundary condition has 2 types: voltage and charge. In this PR an argument is added in assign_balloon() to set voltage or charge boundary condition type.

Issue linked

Issue #5991

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@anur7 anur7 added the bug Something isn't working label Apr 4, 2025
@anur7 anur7 self-assigned this Apr 4, 2025
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 linked an issue Apr 4, 2025 that may be closed by this pull request
2 tasks
@anur7
anur7 marked this pull request as ready for review April 4, 2025 13:32
@codecov

codecov Bot commented Apr 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (824117f) to head (bab7b8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6011      +/-   ##
==========================================
+ Coverage   82.36%   85.06%   +2.70%     
==========================================
  Files         166      166              
  Lines       62978    62980       +2     
==========================================
+ Hits        51870    53574    +1704     
+ Misses      11108     9406    -1702     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve gmalinve left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anur7 well done! you still need to fix a couple of things though ;)

Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/maxwell.py
anur7 and others added 2 commits April 4, 2025 16:31
Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
Co-authored-by: gmalinve <103059376+gmalinve@users.noreply.github.com>
@anur7
anur7 requested a review from gmalinve April 4, 2025 14:39
Comment thread src/ansys/aedt/core/maxwell.py Outdated
@gmalinve
gmalinve requested a review from SMoraisAnsys April 7, 2025 08:08
gmalinve
gmalinve previously approved these changes Apr 7, 2025

@gmalinve gmalinve left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/maxwell.py Outdated

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @anur7 !

@anur7
anur7 merged commit d1c3dc3 into main Apr 7, 2025
@anur7
anur7 deleted the fix-bug-electrostatic-balloon branch April 7, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in assign_balloon() for 2d electrostatic balloon type

5 participants