Skip to content

REFACTOR: Improve assign balloon method#6017

Merged
Samuelopez-ansys merged 3 commits into
mainfrom
refactor/update-assign-balloon-changes
Apr 9, 2025
Merged

REFACTOR: Improve assign balloon method#6017
Samuelopez-ansys merged 3 commits into
mainfrom
refactor/update-assign-balloon-changes

Conversation

@SMoraisAnsys

@SMoraisAnsys SMoraisAnsys commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

Description

Little follow up to #6011 (comment)
On top of updating the docstring (content and typo), I added a warning when the option is used for non Electrostatic solution type.

Issue linked

Associated to #5991

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Apr 7, 2025
Comment thread src/ansys/aedt/core/maxwell.py Outdated
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
@SMoraisAnsys SMoraisAnsys requested a review from anur7 April 7, 2025 14:28
@codecov

codecov Bot commented Apr 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (d1c3dc3) to head (fdf00b3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6017      +/-   ##
==========================================
+ Coverage   82.35%   85.06%   +2.70%     
==========================================
  Files         166      166              
  Lines       62980    62981       +1     
==========================================
+ Hits        51869    53574    +1705     
+ Misses      11111     9407    -1704     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys merged commit 8a677ce into main Apr 9, 2025
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/update-assign-balloon-changes branch April 9, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants