FEAT: populate named expressions and improve doc - #6027
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
added 10 commits
April 10, 2025 09:45
gmalinve
marked this pull request as ready for review
April 15, 2025 12:54
This was
linked to
issues
Apr 15, 2025
gmalinve
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6027 +/- ##
==========================================
- Coverage 85.14% 85.14% -0.01%
==========================================
Files 167 167
Lines 63041 63041
==========================================
- Hits 53675 53674 -1
- Misses 9366 9367 +1 🚀 New features to boost your workflow:
|
added 2 commits
April 16, 2025 11:03
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
Collaborator
There was a problem hiding this comment.
I didn't test the extension changes locally but I checked the documentation. I left some minor comments.
Can you clarify whether you should use "points cloud" or "point cloud" ? Both are used and I think only one of them should be.
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
Collaborator
There was a problem hiding this comment.
Just wondering, would it make sense to also use "PTS" instead of ".pts" in the extension UI ? If yes, please have a look at fields_distribution.py L341
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Contributor
Author
|
@SMoraisAnsys thanks for your comments. |
nunesanderson
pushed a commit
that referenced
this pull request
Apr 30, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> Co-authored-by: Samuelopez-ansys <samuel.lopez@ansys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I added a way to retrieve all named expressions from the fields calculator and improve the doc for both points cloud and fields distribution extensions.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist