Repository navigation
REFACTOR: move add calculation to CommonOptimetrics - #6030
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
gmalinve
marked this pull request as ready for review
April 10, 2025 12:17
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6030 +/- ##
==========================================
+ Coverage 85.08% 85.13% +0.05%
==========================================
Files 166 166
Lines 62977 62936 -41
==========================================
- Hits 53583 53581 -2
+ Misses 9394 9355 -39 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move add_calculation to CommonOptimetrics and remove _add_goal because it's not use anywhere.
add_goal method uses _add_calculation (in CommonOptimetrics). _add_goal was redundant.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist