Skip to content

FIX: Adding close desktop function #6052

Merged
myoung301 merged 14 commits into
mainfrom
FIX__Adding_Close_Desktop_Function
May 1, 2025
Merged

FIX: Adding close desktop function #6052
myoung301 merged 14 commits into
mainfrom
FIX__Adding_Close_Desktop_Function

Conversation

@ramin4667
Copy link
Copy Markdown
Contributor

Description

This PR adds a new function to close the active AEDT.

Issue linked

The function is required to close AEDT after running examples in the PyaEDT examples repo.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label Apr 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (b3713a2) to head (124c403).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6052      +/-   ##
==========================================
- Coverage   85.66%   85.66%   -0.01%     
==========================================
  Files         166      166              
  Lines       62786    62786              
==========================================
- Hits        53788    53786       -2     
- Misses       8998     9000       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will work in 2025R2 right?

@ramin4667 ramin4667 requested a review from myoung301 April 30, 2025 17:34
Copy link
Copy Markdown
Contributor

@myoung301 myoung301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramin4667 A few comments. Overall it's looking good!

Comment thread src/ansys/aedt/core/filtersolutions_core/export_to_aedt.py Outdated
Comment thread src/ansys/aedt/core/filtersolutions.py Outdated
Comment thread src/ansys/aedt/core/filtersolutions_core/export_to_aedt.py Outdated
Comment thread tests/system/solvers/test_45_FilterSolutions/test_desktop_types.py
@myoung301 myoung301 merged commit 6319629 into main May 1, 2025
31 checks passed
@myoung301 myoung301 deleted the FIX__Adding_Close_Desktop_Function branch May 1, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants