Skip to content

REFACTOR: Pathlib hfss.py#6054

Merged
jvela018 merged 5 commits into
mainfrom
refactor/pathlib-hfss
Apr 17, 2025
Merged

REFACTOR: Pathlib hfss.py#6054
jvela018 merged 5 commits into
mainfrom
refactor/pathlib-hfss

Conversation

@jvela018

Copy link
Copy Markdown
Contributor

Issue linked

#5180

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

MaxJPRey
MaxJPRey previously approved these changes Apr 16, 2025

@MaxJPRey MaxJPRey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov

codecov Bot commented Apr 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (979f6c2) to head (dc348de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6054      +/-   ##
==========================================
- Coverage   85.13%   85.13%   -0.01%     
==========================================
  Files         167      167              
  Lines       63042    63041       -1     
==========================================
- Hits        53672    53671       -1     
  Misses       9370     9370              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jvela018
jvela018 requested a review from MaxJPRey April 16, 2025 10:07
@jvela018

Copy link
Copy Markdown
Contributor Author

@MaxJPRey Do you mind approving again. I had to make some additional minor changes to not cast to str when not interacting with the native API. Everything looks pretty much the same except a minor change I made on design.py

@jvela018
jvela018 enabled auto-merge (squash) April 16, 2025 10:10
@jvela018 jvela018 self-assigned this Apr 16, 2025
@jvela018
jvela018 requested a review from gmalinve April 16, 2025 12:42
@jvela018
jvela018 merged commit c6425b6 into main Apr 17, 2025
@jvela018
jvela018 deleted the refactor/pathlib-hfss branch April 17, 2025 07:40
nunesanderson pushed a commit that referenced this pull request Apr 30, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants