REFACTOR: Add examples folder and rework download logic#6055
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
==========================================
- Coverage 85.14% 85.13% -0.01%
==========================================
Files 167 167
Lines 63040 63056 +16
==========================================
+ Hits 53674 53685 +11
- Misses 9366 9371 +5 🚀 New features to boost your workflow:
|
MaxJPRey
reviewed
Apr 17, 2025
MaxJPRey
approved these changes
Apr 22, 2025
Collaborator
Author
|
@Samuelopez-ansys @MaxJPRey Let's wait a bit before merging to see if the pyaedt-examples are not impacted. I'll open a PR to test that :) |
This was referenced Apr 23, 2025
Samuelopez-ansys
pushed a commit
that referenced
this pull request
Apr 24, 2025
This reverts commit 07827c1.
Samuelopez-ansys
pushed a commit
that referenced
this pull request
Apr 24, 2025
…)" This reverts commit 1395f94.
7 tasks
nunesanderson
pushed a commit
that referenced
this pull request
Apr 30, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com> Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR consists in refactoring the downloads logic. While doing so, an architecture refactoring was performed and a folder
examplesis now underansys.aedt.core. It contains the modifieddowloads.pymodule and can be extended with other actions related to the examples.The download refactoring consist in:
github_relative_pathto provide the path to the file/folder in github, use inputfilter_functo specify files/folders to be filtered, usestrip_prefixto remove the original structure (e.g. allowing to download the file"pyaedt/edb/Galileo.aedb/GRM32ER72A225KA35_25C_0V.sp"without creating locally"pyaedt/edb/Galileo.aedb");Issue linked
Associated to #5504
Checklist