Skip to content

FIX: Return value of download_icepak_3d_component#6071

Merged
Samuelopez-ansys merged 3 commits into
mainfrom
fix/examples-download-icepak-3d-component
Apr 24, 2025
Merged

FIX: Return value of download_icepak_3d_component#6071
Samuelopez-ansys merged 3 commits into
mainfrom
fix/examples-download-icepak-3d-component

Conversation

@SMoraisAnsys
Copy link
Copy Markdown
Collaborator

@SMoraisAnsys SMoraisAnsys commented Apr 24, 2025

Description

Following #6055 where the return value of a function was not correctly set.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Apr 24, 2025
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) April 24, 2025 09:09
@github-actions github-actions Bot added the bug Something isn't working label Apr 24, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (96197b2) to head (e87b711).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6071   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files         167      167           
  Lines       63052    63052           
=======================================
  Hits        53677    53677           
  Misses       9375     9375           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys merged commit e100e8b into main Apr 24, 2025
31 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/examples-download-icepak-3d-component branch April 24, 2025 10:08
nunesanderson pushed a commit that referenced this pull request Apr 30, 2025
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants