Skip to content

FIX: Only force download file if specified#6083

Merged
SMoraisAnsys merged 2 commits into
mainfrom
fix/force-download-with-twinbuilder
Apr 27, 2025
Merged

FIX: Only force download file if specified#6083
SMoraisAnsys merged 2 commits into
mainfrom
fix/force-download-with-twinbuilder

Conversation

@SMoraisAnsys

@SMoraisAnsys SMoraisAnsys commented Apr 26, 2025

Copy link
Copy Markdown
Collaborator

Description

As title says. The previous behavior was to recreate the folder even if a specific file was passed as input.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Apr 26, 2025
@github-actions github-actions Bot added the bug Something isn't working label Apr 26, 2025
@codecov

codecov Bot commented Apr 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (2b3fc22) to head (284cf39).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6083      +/-   ##
==========================================
+ Coverage   82.53%   85.15%   +2.62%     
==========================================
  Files         167      167              
  Lines       63120    63122       +2     
==========================================
+ Hits        52093    53754    +1661     
+ Misses      11027     9368    -1659     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys merged commit 96d5a9b into main Apr 27, 2025
@SMoraisAnsys SMoraisAnsys deleted the fix/force-download-with-twinbuilder branch April 27, 2025 07:04
nunesanderson pushed a commit that referenced this pull request Apr 30, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants