Skip to content

FEAT: Uncover face - #6122

Merged
Samuelopez-ansys merged 28 commits into
mainfrom
add/uncover_face
May 13, 2025
Merged

Samuelopez-ansys merged 28 commits into
mainfrom
add/uncover_face

Conversation

@jvela018

@jvela018 jvela018 commented May 7, 2025

Copy link
Copy Markdown
Contributor

Description

Creation of a method uncover_face in the modeler class.

Issue linked

#6100

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov

codecov Bot commented May 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (ee79807) to head (dc2d1d4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6122   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files         167      167           
  Lines       63637    63657   +20     
=======================================
+ Hits        54247    54269   +22     
+ Misses       9390     9388    -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys

Copy link
Copy Markdown
Member

@jvela018 Is it not possible to uncover multiple faces in one single call? Please test it, because if the API allows multi-face selection, the PyAEDT method should also allow it. Thanks!

@jvela018
jvela018 marked this pull request as draft May 8, 2025 06:24
@jvela018
jvela018 marked this pull request as ready for review May 12, 2025 11:53
@jvela018

Copy link
Copy Markdown
Contributor Author

@jvela018 Is it not possible to uncover multiple faces in one single call? Please test it, because if the API allows multi-face selection, the PyAEDT method should also allow it. Thanks!

@Samuelopez-ansys I added multi face selection. Is this implementation ok? Thanks

Comment thread src/ansys/aedt/core/modeler/cad/primitives.py
Comment thread tests/system/general/test_08_Primitives3D.py Outdated
Comment thread src/ansys/aedt/core/modeler/cad/primitives.py Outdated
Comment thread src/ansys/aedt/core/modeler/cad/primitives.py
Comment thread src/ansys/aedt/core/modeler/cad/primitives.py Outdated
jvela018 and others added 2 commits May 12, 2025 15:44
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
Comment thread src/ansys/aedt/core/modeler/cad/primitives.py Outdated
Comment thread src/ansys/aedt/core/modeler/cad/primitives.py
Comment thread tests/system/general/test_08_Primitives3D.py
jvela018 and others added 2 commits May 12, 2025 15:55
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
@jvela018
jvela018 requested a review from Samuelopez-ansys May 13, 2025 12:28

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys
Samuelopez-ansys merged commit 5addaec into main May 13, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the add/uncover_face branch May 13, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants