Skip to content

FIX: External circuit import of renamed sources - #6128

Merged
Samuelopez-ansys merged 10 commits into
mainfrom
fix/issue_6127
May 8, 2025
Merged

FIX: External circuit import of renamed sources #6128
Samuelopez-ansys merged 10 commits into
mainfrom
fix/issue_6127

Conversation

@vpipidis

@vpipidis vpipidis commented May 8, 2025

Copy link
Copy Markdown
Contributor

Description

Created a check whether the source has a custom name before evaluating the label to pass as an argument on Maxwell3D.edit_external_circuit

Issue linked

#6127

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@vpipidis
vpipidis requested a review from Samuelopez-ansys May 8, 2025 10:10
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label May 8, 2025
@codecov

codecov Bot commented May 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (fc81bcc) to head (8fc8141).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6128      +/-   ##
==========================================
+ Coverage   85.14%   85.16%   +0.01%     
==========================================
  Files         167      167              
  Lines       63596    63602       +6     
==========================================
+ Hits        54148    54164      +16     
+ Misses       9448     9438      -10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/maxwell.py Outdated
vpipidis and others added 2 commits May 8, 2025 15:47
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>

@Samuelopez-ansys Samuelopez-ansys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @vpipidis ! Your first PR, Congrats

@Samuelopez-ansys
Samuelopez-ansys merged commit 9f0b2b0 into main May 8, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the fix/issue_6127 branch May 8, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants