Skip to content

FEAT: Add circuit extension - #6143

Merged
gkorompi merged 22 commits into
mainfrom
circuit_config_extension
May 19, 2025
Merged

gkorompi merged 22 commits into
mainfrom
circuit_config_extension

Conversation

@gkorompi

Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gkorompi gkorompi linked an issue May 11, 2025 that may be closed by this pull request
@github-actions github-actions Bot added the maintenance Package and maintenance related label May 11, 2025
@codecov

codecov Bot commented May 11, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (852dab1) to head (3c467ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6143      +/-   ##
==========================================
+ Coverage   85.20%   85.26%   +0.05%     
==========================================
  Files         169      170       +1     
  Lines       64041    64095      +54     
==========================================
+ Hits        54568    54649      +81     
+ Misses       9473     9446      -27     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys changed the title FIX: circuit extensions FEAT: Add circuit extension May 13, 2025
@SMoraisAnsys

Copy link
Copy Markdown
Collaborator

@gkorompi I updated your PR's title as your changes are clearly a feature and not a fix. Please have a look at https://www.conventionalcommits.org/en/v1.0.0/ for more information

@hui-zhou-a hui-zhou-a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unittest

@gkorompi
gkorompi requested a review from a team as a code owner May 19, 2025 13:45
@gkorompi
gkorompi enabled auto-merge (squash) May 19, 2025 13:45
@gkorompi
gkorompi requested a review from Samuelopez-ansys May 19, 2025 17:26
@gkorompi
gkorompi merged commit 1ee0131 into main May 19, 2025
@gkorompi
gkorompi deleted the circuit_config_extension branch May 19, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circuti config extension

5 participants