Skip to content

CHORE: 2025.2 compatibility - #6152

Merged
Samuelopez-ansys merged 97 commits into
mainfrom
chore/2025_2_compatibility
Jun 5, 2025
Merged

CHORE: 2025.2 compatibility#6152
Samuelopez-ansys merged 97 commits into
mainfrom
chore/2025_2_compatibility

Conversation

@Samuelopez-ansys

Copy link
Copy Markdown
Member

Description

This PR fixes some compatibility issues with 2025R2 version.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys
Samuelopez-ansys marked this pull request as ready for review June 3, 2025 06:19
@Samuelopez-ansys
Samuelopez-ansys requested a review from a team as a code owner June 3, 2025 06:19

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I just left some minor comments to be addressed. Thanks for the work @Samuelopez-ansys

Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/maxwell.py
Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/maxwell.py
Comment thread src/ansys/aedt/core/maxwell.py Outdated
Comment thread src/ansys/aedt/core/visualization/post/common.py
Comment thread tests/system/filter_solutions/test_desktop_types.py
@Samuelopez-ansys
Samuelopez-ansys enabled auto-merge (squash) June 5, 2025 08:50
@Samuelopez-ansys
Samuelopez-ansys disabled auto-merge June 5, 2025 08:50
SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 5, 2025

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor remark

Comment thread .github/workflows/ci_cd.yml
@Samuelopez-ansys
Samuelopez-ansys merged commit d60b7ef into main Jun 5, 2025
@Samuelopez-ansys
Samuelopez-ansys deleted the chore/2025_2_compatibility branch June 5, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants