Skip to content

FIX: Change default report resolution on VirtualCompliance#6177

Merged
maxcapodi78 merged 9 commits into
mainfrom
fix_report_resolution
May 21, 2025
Merged

FIX: Change default report resolution on VirtualCompliance#6177
maxcapodi78 merged 9 commits into
mainfrom
fix_report_resolution

Conversation

@maxcapodi78

Copy link
Copy Markdown
Member

Description

Change default report resolution on VirtualCompliance to 800x450 to keep 16:9 aspect ratio.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@maxcapodi78
maxcapodi78 requested a review from a team as a code owner May 21, 2025 06:57
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label May 21, 2025
@codecov

codecov Bot commented May 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (18d06d8) to head (a31caa4).
Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (82.60%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6177      +/-   ##
==========================================
+ Coverage   84.41%   85.24%   +0.82%     
==========================================
  Files         170      170              
  Lines       64112    64127      +15     
==========================================
+ Hits        54122    54663     +541     
+ Misses       9990     9464     -526     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to directly change the default size in export_report_to_jpg ? Instead of having 0,0 by default, change it to 800,450 ?

@maxcapodi78

Copy link
Copy Markdown
Member Author

Wouldn't it be better to directly change the default size in export_report_to_jpg ? Instead of having 0,0 by default, change it to 800,450 ?

That's a good idea. I was just worried could have some (very limited impact on some user)

@maxcapodi78
maxcapodi78 enabled auto-merge (squash) May 21, 2025 12:35
@maxcapodi78
maxcapodi78 requested a review from SMoraisAnsys May 21, 2025 12:35
@maxcapodi78

Copy link
Copy Markdown
Member Author

Wouldn't it be better to directly change the default size in export_report_to_jpg ? Instead of having 0,0 by default, change it to 800,450 ?

I added it and I've also parametrized Virtual compliance one. Please review it

@maxcapodi78
maxcapodi78 dismissed SMoraisAnsys’s stale review May 21, 2025 14:49

Implemented suggestion

@maxcapodi78
maxcapodi78 merged commit 459f92f into main May 21, 2025
@maxcapodi78
maxcapodi78 deleted the fix_report_resolution branch May 21, 2025 14:49
jsalant22 pushed a commit that referenced this pull request Jun 3, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants