Skip to content

FIX: Check if property key exist in boundary for configuration file#6180

Merged
Samuelopez-ansys merged 5 commits into
mainfrom
fix/issue_6179
May 23, 2025
Merged

FIX: Check if property key exist in boundary for configuration file#6180
Samuelopez-ansys merged 5 commits into
mainfrom
fix/issue_6179

Conversation

@siva-krishnaswamy

@siva-krishnaswamy siva-krishnaswamy commented May 21, 2025

Copy link
Copy Markdown
Contributor

Description

Avoid error if the property is not part of the boundary keys.

Issue linked

Close #6179

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

…. the underlying dictionary is changed. This avoids error as we are not setting props.
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label May 21, 2025
@siva-krishnaswamy siva-krishnaswamy changed the title fix for issue 6179. Instead of assinging dictionary directly to props… FIX: fix for issue 6179. Instead of assinging dictionary directly to props… May 21, 2025
@codecov

codecov Bot commented May 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (851b4ec) to head (84a1347).
Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6180      +/-   ##
==========================================
+ Coverage   82.66%   85.25%   +2.58%     
==========================================
  Files         170      170              
  Lines       64119    64118       -1     
==========================================
+ Hits        53003    54662    +1659     
+ Misses      11116     9456    -1660     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Samuelopez-ansys Samuelopez-ansys changed the title FIX: fix for issue 6179. Instead of assinging dictionary directly to props… FIX: Check if property key exist in boundary for configuration file May 23, 2025
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) May 23, 2025 08:20
@Samuelopez-ansys Samuelopez-ansys merged commit bf92f55 into main May 23, 2025
35 of 36 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_6179 branch May 23, 2025 10:21
jsalant22 pushed a commit that referenced this pull request Jun 3, 2025
…6180)

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in importing configuration for boundaries

3 participants