Skip to content

FIX: LSF submission string error 6182#6208

Merged
Samuelopez-ansys merged 3 commits into
mainfrom
fix/6187_lsf
May 28, 2025
Merged

FIX: LSF submission string error 6182#6208
Samuelopez-ansys merged 3 commits into
mainfrom
fix/6187_lsf

Conversation

@Devin-Crawford

@Devin-Crawford Devin-Crawford commented May 27, 2025

Copy link
Copy Markdown
Contributor

Fix issue 6187 for LSF custom string submission.

Description

Use shlex.split() to convert the lsf command to a list.

Issue linked

Close #6187

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Fix issue 6187 for LSF custom string submission.
@Devin-Crawford Devin-Crawford requested a review from a team as a code owner May 27, 2025 19:51
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the bug Something isn't working label May 27, 2025
@codecov

codecov Bot commented May 27, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (8dd5579) to head (68382a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6208   +/-   ##
=======================================
  Coverage   85.22%   85.23%           
=======================================
  Files         170      170           
  Lines       64168    64169    +1     
=======================================
+ Hits        54687    54694    +7     
+ Misses       9481     9475    -6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit d02f4d2 into main May 28, 2025
@Samuelopez-ansys Samuelopez-ansys deleted the fix/6187_lsf branch May 28, 2025 07:10
jsalant22 pushed a commit that referenced this pull request Jun 3, 2025
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in launch_aedt_in_lsf() inside desktop.py

4 participants